search

nmdias / FeedParser

An RSS and Atom feed parser written in Swift
MIT License
11 stars 1 forks source link

FeedParser class and namespace #2

Closed JARMourato closed 8 years ago

JARMourato commented 8 years ago

Hi, I'm facing an issue with your library. I have already an implementation of Result Enum in my project. Since your module FeedParser has a class named exactly the same I cannot specify in my code your version of Result as FeedParser.Result since XCode always assumes the class FeedParser type.

nmdias commented 8 years ago

Nice catch @JARMourato I'll release a fix for this. Thanks :)

JARMourato commented 8 years ago

Don't know what your approach will be..but either changing the module name in the podspec or the class name should get the job done. Many thanks @nmdias happy to help ;)

nmdias commented 8 years ago

Agree. I'll probably rename the class to Parser and be done with it. Renaming the module as too many ramifications, and would have to actually rename the entire framework, submit a new pod under a new name and thus reducing the change of discoverability....and so on.

JARMourato commented 8 years ago

You can specify in the podspec a variable named modulename, and nothing changes other than the import FeedParser changing to (e.g. FeedParserFramework). Just letting you know, either way is fine by me :)

nmdias commented 8 years ago

The framework has now been renamed FeedKit and moved to a new repository. Naming collisions between the module import and the FeedParser class name should no longer pose any issues.

Thank you again for reporting this issue @JARMourato