nmdickson / GCfit

Multimass (LIMEPY) globular cluster equilibrium models and fitting them to observations
https://gcfit.readthedocs.io
MIT License
3 stars 1 forks source link

small fix to import #169

Closed pjs902 closed 1 year ago

pjs902 commented 1 year ago

Just a small importing change that got missed in the package restructure.

nmdickson commented 1 year ago

Did this actually break anything for you? As far as I know Observations is in the gcfit namespace, and should be importing just fine from .. directly.

pjs902 commented 1 year ago

Yeah, it wouldn't import Observations for me without the change, not sure why it isn't in the top-level name space.

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[3], line 3
      1 import gcfit
      2 from gcfit.core import Observations, FittableModel
----> 3 from gcfit.analysis import ObservationsVisualizer

File ~/research/GCfit/gcfit/analysis/__init__.py:7
      1 '''
      2 visualize
      3 
      4 fitting run and model parameter visualizations and summaries
      5 '''
----> 7 from .runs import *
      8 from .models import *

File ~/research/GCfit/gcfit/analysis/runs.py:1
----> 1 from .. import Observations
      2 from ..probabilities import priors
      3 from .models import CIModelVisualizer, ModelVisualizer, ModelCollection

ImportError: cannot import name 'Observations' from 'gcfit' (unknown location)
pjs902 commented 1 year ago

Update, this works totally fine outside of Jupyter so there's something else going on here.