nmdp-bioinformatics / gfe-db

Graph database representing IPD-IMGT/HLA sequence data as GFE
https://gfe-db.readthedocs.io
GNU General Public License v3.0
9 stars 15 forks source link

Fix incorrect comparison operator causing 3350 to fail #75

Closed chrisammon3000 closed 1 year ago

chrisammon3000 commented 1 year ago

Description

The build script was using when it should have been using <:

echo "Downloading DAT file for release $release..."
if [ "$(echo "$release" | bc -l)" -le 3350  ]; then

This was causing the script to access the wrong download URL for the DAT for that version resulting in no data.

Fix:

echo "Downloading DAT file for release $release..."
if [ "$(echo "$release" | bc -l)" -lt 3350  ]; then

Notes

In addition to the error fix, the deployment platform is specified when building the Docker image to avoid issues when working on M1/M2 Macs:

    docker build \
        -t "$${BUILD_REPOSITORY}" \
        --platform "linux/amd64" \ # M1/M2 Macs use "linux/arm64" but AWS Batch is not currently
        build/ && \