search

nmdp-bioinformatics / phycus

Service used for curation of Haplotype Frequency
GNU Lesser General Public License v3.0
7 stars 21 forks source link

Update the Java client to accommodate new LabelData structure #90

Closed kaeaton closed 5 years ago

kaeaton commented 5 years ago

LabelData and MethodData now directly include LabelList and MethodList. This update fixes the Java client so that it adds data to LabelData appropriately.

kaeaton commented 5 years ago

Terribly sorry, I must have accidentally deleted part of the file. (That's not the .gitignore I altered, and I returned that one to it's prior state.) The file has been repaired.

fscheel commented 5 years ago

Great! But sadly the now ignored files are still in the PR. Could you clean those up as well? https://stackoverflow.com/a/23839198 might help.

kaeaton commented 5 years ago

I made the changes, and just to check, recompiled the program. Something about compiling the program causes part of the .gitignore file to disappear which is how it picked up all those extra files. Do you have any ideas about what could cause that? I'm at a loss.

fscheel commented 5 years ago

That might be the swagger codegen also generating the .gitignore file... https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-to-skip-certain-files-during-code-generation might be a solution for that.

kaeaton commented 5 years ago

Let me submit a new pull request with the changes removing LabelList and I'll work on the .gitignore after.