search

nmdp-bioinformatics / phycus

Service used for curation of Haplotype Frequency
GNU Lesser General Public License v3.0
7 stars 23 forks source link

Remove LabelList usage from the Java client #91

Closed kaeaton closed 6 years ago

kaeaton commented 6 years ago

Incorporates the changes to LabelData in the Swagger client.

fscheel commented 6 years ago

That looks far better! Now if we could avoid the tabs vs spaces debate...

kaeaton commented 6 years ago

I will fix that. Is it alright if I use depth of 4 spaces per tab instead of 8?

fscheel commented 6 years ago

I wouldn't mind a narrower indentation. Not sure if @mpresteg feels strongly about this.

kaeaton commented 6 years ago

It's currently set to tabs. The lines I changed Are currently set to 4 space tabs, but I double tabbed so that it still looks like 8. I also added a test data folder I need to the client. They're dummy data for testing the clients and have no impact on any of the code.

mpresteg commented 6 years ago

I wouldn't mind a narrower indentation. Not sure if @mpresteg feels strongly about this.

Narrower is fine. Any formatting preferences I may have established were not necessarily intentional.

kaeaton commented 6 years ago

Sorry to add one more commit to this, but I fixed the problem where swagger was rewriting the .gitignore file and generating junk files. It seemed important to add that as soon as possible.

fscheel commented 6 years ago

Sorry for having time to look at this only now, but why did you close this PR? Want me to separate your LabelList changes and get those merged in?

kaeaton commented 6 years ago

Can you sort out that last commit? (ec5333c) That one isn't ready yet. The rest is removing label list, adding some test files, and adding .gitignore to the correct .swagger-codegen-ignore and should all go in.

fscheel commented 6 years ago

I'm closing this in favour for #92