search

nmdp-bioinformatics / phycus

Service used for curation of Haplotype Frequency
GNU Lesser General Public License v3.0
7 stars 23 forks source link

Adding the GUI #95

Closed kaeaton closed 5 years ago

kaeaton commented 5 years ago

The entire thing has been written in its own folder, and should not impact any facet of the back end or the other clients. I also added a folder containing some test files. Feel free to use them to test the program. (You can select each file individually or bulk upload the whole folder. The folder option will only attempt to process the csv files.)

pbashyal-nmdp commented 5 years ago

Hi Katrina,

I'm having trouble building javaGui. I get the following error:

Failed to execute goal on project freq-tools: Could not resolve dependencies for project org.dash.freq:freq-tools:jar:0.0.1-SNAPSHOT: Failure to find unknown.binary:AbsoluteLayout:jar:SNAPSHOT

I see that javaGui/freq-tools/pom.xml has the following dependency:

    <dependency>
      <groupId>unknown.binary</groupId>
      <artifactId>AbsoluteLayout</artifactId>
      <version>SNAPSHOT</version>
    </dependency>

Where is that coming from ?

kaeaton commented 5 years ago

I don't know. It got added back in April according to the file history, but I'm not sure how. My best guess is it's a Maven dependency I added that got pulled or otherwise broken. If it's the one I think it was, it wasn't implemented yet anyway, and can be removed. (I tried deleting it and it compiled and worked for me. On the other hand, it compiled and worked for me before, so...)

pbashyal-nmdp commented 5 years ago

Thanks. It builds now. If you just push your changes to the same branch it will show up on the PR.

Will take a look at the code tomorrow.

pbashyal-nmdp commented 5 years ago

👍 LGTM

Thanks for considering the changes, it looks great! I have some ideas to improve the UI but we can discuss that during the hackathon.