search

nmdp-bioinformatics / pipeline

Consensus assembly and allele interpretation pipeline.
GNU Lesser General Public License v3.0
7 stars 7 forks source link

Update report #112

Closed mhalagan closed 9 years ago

mhalagan commented 9 years ago
ghost commented 9 years ago

Some of the file diffs are too large for line by line comments.

This needs to be a parameter or configuration option:

my $url = "http://emmes-dev.nmdp.org:8080/ac/api/decode?typing=$loc*$typ";

https://github.com/mhalagan-nmdp/pipeline/blob/b724fac48289a9c20916348e0c48c39e7856916c/validation/ngs-validation-report#L1057

This copyright statement is not compatible with our license

<a href="http://bioinformatics.nmdp.org/Copyright_Information.aspx">Copyright ©</a> 2006 - 2014 National...

https://github.com/mhalagan-nmdp/pipeline/blob/b724fac48289a9c20916348e0c48c39e7856916c/validation/lib/html.pm#L1331 (and several other places)

ghost commented 9 years ago

I just noticed that the commits in this pull request are from user @mhalagan and not @mhalagan-nmdp who opened up the pull request. With that and the commits to files outside of the validation directory, maybe these commits should be squashed or another new pull request be created?

mhalagan commented 9 years ago

The copy right statement it's linked too or the 2006 - 2014 part??

      <p><a href="http://bioinformatics.nmdp.org/Copyright_Information.aspx">Copyright ©</a> 2006 - 2014 National Marrow Donor Program. All Rights Reserved.</p>

Could it be changed to something like this:

      <p><a href="https://github.com/nmdp-bioinformatics/pipeline/blob/master/LICENSE">Copyright ©</a> 2014 - 2015 National Marrow Donor Program. All Rights Reserved.</p>

From: Michael Heuer (NMDP) [notifications@github.com] Sent: Thursday, May 07, 2015 2:39 PM To: nmdp-bioinformatics/pipeline Cc: Michael Halagan Subject: Re: [pipeline] Update report (#112)

Some of the file diffs are too large for line by line comments.

This needs to be a parameter or configuration option:

my $url = "http://emmes-dev.nmdp.org:8080/ac/api/decode?typing=$loc*$typ";

https://github.com/mhalagan-nmdp/pipeline/blob/b724fac48289a9c20916348e0c48c39e7856916c/validation/ngs-validation-report#L1057

This copyright statement is not compatible with our license

Copyright © 2006 - 2014 National...

https://github.com/mhalagan-nmdp/pipeline/blob/b724fac48289a9c20916348e0c48c39e7856916c/validation/lib/html.pm#L1331 (and several other places)

— Reply to this email directly or view it on GitHubhttps://github.com/nmdp-bioinformatics/pipeline/pull/112#issuecomment-99992193.

mhalagan commented 9 years ago

"I just noticed that the commits in this pull request are from user @mhalagan and not @mhalagan-nmdp who opened up the pull request. With that and the commits to files outside of the validation directory, maybe these commits should be squashed or another new pull request be created?"

My git config user.email was set to mhalagan09@gmail.com (mhalagan on github), so I just changed it to mhalagan@nmdp.org.