nmdp-bioinformatics / pipeline

Consensus assembly and allele interpretation pipeline.
GNU Lesser General Public License v3.0
7 stars 7 forks source link

groovy script library requirements #39

Closed janders3-nmdp closed 9 years ago

janders3-nmdp commented 9 years ago

It's still pulling libraries out of Caleb's Homedir, and the /tmp/hla-a.txt file.

We should add hla-a.txt into tutorial, and ensure the required libraries are in a system directory, so I can mirror them into an AMI.

The Tutorial documentation should then also be updated.

ghost commented 9 years ago

Alternatively, we could build the groovy script using gradle, ant, ivy, or maven, and build an executable using a groovy build plugin equivalent to the maven appassembler plugin.

janders3-nmdp commented 9 years ago

I rather like that approach -- would it allow us to include the various hla-*.txt files directly into it, and just select them with something like a command-line flag?

ckennedy-nmdp commented 9 years ago

We could do that, although we're almost done porting to Java anyway. Probably best to wait.

C

ckennedy-nmdp commented 9 years ago

I think we should have a post-hackathon release relatively soon, perhaps coinciding with publication of HML 1.0.

ghost commented 9 years ago

@ckennedy-nmdp ping, we desperately need this

ckennedy-nmdp commented 9 years ago
andersje commented 9 years ago

Is this just the list of required libraries I need to add into the repo? Or is there also an associated PR somewhere which incorporates these?

ghost commented 9 years ago

splice-bam.groovy may be replaced in the near future by the port to java, ngs-filter-consensus

https://github.com/nmdp-bioinformatics/ngs/pull/59

ghost commented 9 years ago

@ckennedy-nmdp can splice-bam.groovy be removed from the git repo and this issue be closed at this point?

ckennedy-nmdp commented 9 years ago

Yes, the Java port has been fully validated. Please deprecate splice-bam.groovy and remove from the repository.

ghost commented 9 years ago

Cloing this as WontFix, created new issue #89