nmdp-bioinformatics / py-ard

HLA ARD Reduction in Python
https://py-ard.org/
GNU Lesser General Public License v3.0
17 stars 13 forks source link

dupes now appearing in "G" mode #337

Open mmaiers-nmdp opened 2 days ago

mmaiers-nmdp commented 2 days ago

image This is a Google Colab session with these three commands

pip install py-ard

installs version 1.5.3

import pyard

ard = pyard.init()

and

ard.redux("HLA-A*02:GNF", "G")

which returns

HLA-A*02:01:01G/HLA-A*02:01:02G

We need this to be dupe squashed. Isn't this the default?

mmaiers-nmdp commented 1 day ago

same problem for redux mode "P" but not "lg", "lgx" image

pbashyal-nmdp commented 1 day ago

The dupes are only "squashed" for ARD level. #333

mmaiers-nmdp commented 16 hours ago

Let’s extend that to all resolutions. Arguably a glstring with X/X is semantically correct. I can’t think of any reason why there shouldn’t be a general dupe squashing (within allele ambiguities) within all glstring every time everywhere.