nmdp-bioinformatics / service-feature

Enumerated sequence feature service.
GNU Lesser General Public License v3.0
2 stars 10 forks source link

Enforce DNA alphabet for feature sequences #48

Closed heuermh closed 7 years ago

heuermh commented 7 years ago

Fixes #30

fscheel commented 7 years ago

Shouldn't the regex be ^[ACTG]*$? Also not sure whether the sequence may be the empty string...

heuermh commented 7 years ago

@fscheel Yep, you're right. My regex skills are rusty. Will fix and rebase.

fscheel commented 7 years ago

:+1: Since we'll disallow empty strings in another PR

heuermh commented 7 years ago

Thanks!