search

nmelnick / whatbot

whatbot: A sane bot for most chat applications, written in modern Perl
http://www.whatbot.org
10 stars 7 forks source link

Ratbox ircd authentication compatibility issue #24

Closed robisonjoel closed 10 years ago

robisonjoel commented 10 years ago

it appears that ratbox ircd sends authentication message back to the client via an unexpected channel:

Use of uninitialized value $nick in substitution (s///) at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot/IO/IRC.pm line 228.
unhandled callback exception on event (privatemsg, AnyEvent::IRC::Client=HASH(0x55f98d0), AUTH HASH(0x763dc18)): Attribute (from) does not pass the type constraint because: Validation failed for 'Str' with value undef at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Exception.pm line 37
        Moose::Exception::_build_trace('Moose::Exception::ValidationFailedForInlineTypeConstraint=HASH(0x775a320)') called at reader Moose::Exception::trace (defined at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Exception.pm line 9) line 8
        Moose::Exception::trace('Moose::Exception::ValidationFailedForInlineTypeConstraint=HASH(0x775a320)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Exception.pm line 49
        Moose::Exception::BUILD('Moose::Exception::ValidationFailedForInlineTypeConstraint=HASH(0x775a320)', 'HASH(0x775a1e8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Class/MOP/Method.pm line 128
        Class::MOP::Method::execute('Moose::Meta::Method=HASH(0x77369a0)', 'Moose::Exception::ValidationFailedForInlineTypeConstraint=HASH(0x775a320)', 'HASH(0x775a1e8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Object.pm line 56
        Moose::Object::BUILDALL('Moose::Exception::ValidationFailedForInlineTypeConstraint=HASH(0x775a320)', 'HASH(0x775a1e8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Meta/Class.pm line 282
        Moose::Meta::Class::new_object('Moose::Meta::Class=HASH(0x772d008)', 'HASH(0x775a1e8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Object.pm line 27
        Moose::Object::new('Moose::Exception::ValidationFailedForInlineTypeConstraint', 'type_constraint_message', 'Validation failed for \'Str\' with value undef', 'class_name', 'whatbot::Message', 'attribute_name', 'from', 'value', undef) called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/Moose/Util.pm line 52
        Moose::Util::throw_exception('ValidationFailedForInlineTypeConstraint', 'type_constraint_message', 'Validation failed for \'Str\' with value undef', 'class_name', 'whatbot::Message', 'attribute_name', 'from', 'value', undef) called at constructor whatbot::Message::new (defined at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot/Message.pm line 180) line 44
        whatbot::Message::new('whatbot::Message', 'HASH(0x77d0530)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot/IO.pm line 146
        whatbot::IO::get_new_message('whatbot::IO::IRC=HASH(0x482fd88)', 'HASH(0x77d04b8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot/IO/IRC.pm line 233
        whatbot::IO::IRC::cb_message('whatbot::IO::IRC=HASH(0x482fd88)', 'AnyEvent::IRC::Client=HASH(0x55f98d0)', 'AUTH', 'HASH(0x763dc18)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot/IO/IRC.pm line 87
        whatbot::IO::IRC::__ANON__('AnyEvent::IRC::Client=HASH(0x55f98d0)', 'AUTH', 'HASH(0x763dc18)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/Object/Event.pm line 451
        eval {...} at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/Object/Event.pm line 450
        Object::Event::event('AnyEvent::IRC::Client=HASH(0x55f98d0)', 'privatemsg', 'AUTH', 'HASH(0x763dc18)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/AnyEvent/IRC/Client.pm line 1389
        AnyEvent::IRC::Client::privmsg_cb('AnyEvent::IRC::Client=HASH(0x55f98d0)', 'HASH(0x763dc18)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/Object/Event.pm line 451
        eval {...} at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/Object/Event.pm line 450
        Object::Event::event('AnyEvent::IRC::Client=HASH(0x55f98d0)', 'irc_notice', 'HASH(0x763dc18)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/AnyEvent/IRC/Connection.pm line 239
        AnyEvent::IRC::Connection::_feed_irc_data('AnyEvent::IRC::Client=HASH(0x55f98d0)', 'NOTICE AUTH :*** Found your hostname') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/AnyEvent/IRC/Connection.pm line 136
        AnyEvent::IRC::Connection::__ANON__('AnyEvent::Handle=HASH(0x5687fd8)', 'NOTICE AUTH :*** Found your hostname', '^M^J') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/AnyEvent/Handle.pm line 1546
        AnyEvent::Handle::__ANON__('AnyEvent::Handle=HASH(0x5687fd8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/AnyEvent/Handle.pm line 1310
        AnyEvent::Handle::_drain_rbuf('AnyEvent::Handle=HASH(0x5687fd8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/AnyEvent/Handle.pm line 2094
        AnyEvent::Handle::_dotls('AnyEvent::Handle=HASH(0x5687fd8)') called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/x86_64-linux-thread-multi/AnyEvent/Handle.pm line 2007
        AnyEvent::Handle::__ANON__('EV::IO=SCALAR(0x770d7f8)', 1) called at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot.pm line 143
        eval {...} at /whatbot/perl5/perlbrew/perls/perl-blead/lib/site_perl/5.20.0/whatbot.pm line 143
        whatbot::run('whatbot=HASH(0x1450398)') called at /whatbot/whatbot-deploy/bin/whatbot line 54
nmelnick commented 10 years ago

For now, ignoring messages without a NICK as of ebb93e4.