search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

adb: Enable mdns commands #101

Closed Biswa96 closed 1 year ago

nmeum commented 1 year ago

Thanks for the PR! The only issue I see with this is that it pulls in a lot of new code and as such will make it more difficult to update and maintain everything in the future. So—as always—there is a trade-off between usability/convenience and maintenance burden here[^1]. I personally don't need/use the mdns feature, but I would be fine with merging this if other people want/need this feature.

[^1]: There is probably also an argument to be made that one can use the official android-sdk if a fully featured adb version is needed.

Biswa96 commented 1 year ago

OK, no comment so far. Feel free to copy or modify the code from this pull request.