search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
176 stars 51 forks source link

cmake: Remove redundant libfsmgr library #105

Closed Biswa96 closed 1 year ago

Biswa96 commented 1 year ago

It is same as liblp and that name is officially used with fastboot. See https://android.googlesource.com/platform/system/core.git/+/refs/tags/platform-tools-33.0.3/fastboot/Android.bp

Biswa96 commented 1 year ago

The build failure in fedora rawhide was fixed in 34.0.0 version. See the source file here https://android.googlesource.com/platform/packages/modules/adb.git/+/refs/tags/platform-tools-34.0.0/file_sync_protocol.h. It will be added in next version update, so I skipped that patch here.

Biswa96 commented 1 year ago

May I ask to review this pull request please?

anatol commented 1 year ago

The change looks good to me.

anatol commented 1 year ago

cc @nmeum

anatol commented 1 year ago

Thank you for your contribution. The fedora breakage is unrelated to your change.