search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
176 stars 51 forks source link

Upgrade to platform-tools-34.0.3 #115

Closed Biswa96 closed 1 year ago

Biswa96 commented 1 year ago

This may break RISC-V platform. This commit may be the reason https://boringssl.googlesource.com/boringssl/+/1967621cc9498a4d775a8a9eaabbcb7a52be8316

anatol commented 1 year ago

Is it possible to port (or even better upstream) the cmake files?

anatol commented 1 year ago

Cc @SpriteOvO

SpriteOvO commented 1 year ago

For RISC-V, looks like it just needs a simple patch, I will try to upstream it to boringssl in the next few days.

SpriteOvO commented 1 year ago

I have compiled the latest boringssl without patching on RISC-V. That commit did not break RISC-V since it just added code files for specific arch and RISC-V doesn't need specific files.

However, the latest boringssl triggers a strange error that looks like a bug from STL or gcc, I'm trying to investigate it, it doesn't relate to android-tools or boringssl I guess, so this PR can be merged safely, and no porting is needed :)

anatol commented 1 year ago

Thank you for the confirmation @SpriteOvO

nmeum commented 1 year ago

Thank you for the PR! Should I tag a new release or does this warrant further testing? (: