Closed csfore closed 9 months ago
LGTM.
@csfore could you please also send these changes to upstream Android team?
Also, do you have a link to a compilation report done with GCC 14 (some CI maybe) that shows the failure?
I sent the patches up a couple of couple of days ago :slightly_smiling_face:
https://android-review.googlesource.com/c/platform/system/core/+/2839495 https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578
And for the build error, would attaching the output of make
suffice for each?
Here are the build logs for each of them
Thank you for your work @csfore
Thank you! Hopefully it's merged upstream soon enough
@anatol Hello! Those two patches I sent upstream were merged finally (first one was a couple of days ago but wanted to wait for both before I reached out), I'm not entirely sure how you update the project but just wanted to let you know!
Thank you for handling the upstreaming process!
First upstream needs to make a new release with these patches. Then android-tools
bumps to that release. At this point the patches will no longer needed in the android-tools
repo and can be dropped.
First upstream needs to make a new release with these patches.
Would it be possible to request a new tag in upstream aosp? platform tools version 34.0.5 was released in October 2023^1.
I too need this update please :pray:.
By default GCC 14 no longer includes, so it has to be explicitly imported now.