search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Import <algorithm> to build on GCC 14 #129

Closed csfore closed 9 months ago

csfore commented 9 months ago

By default GCC 14 no longer includes , so it has to be explicitly imported now.

anatol commented 9 months ago

LGTM.

@csfore could you please also send these changes to upstream Android team?

anatol commented 9 months ago

Also, do you have a link to a compilation report done with GCC 14 (some CI maybe) that shows the failure?

csfore commented 9 months ago

I sent the patches up a couple of couple of days ago :slightly_smiling_face:

https://android-review.googlesource.com/c/platform/system/core/+/2839495 https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578

And for the build error, would attaching the output of make suffice for each?

csfore commented 9 months ago

Here are the build logs for each of them

core-output.log adb-output.log

anatol commented 9 months ago

Thank you for your work @csfore

csfore commented 9 months ago

Thank you! Hopefully it's merged upstream soon enough

csfore commented 9 months ago

@anatol Hello! Those two patches I sent upstream were merged finally (first one was a couple of days ago but wanted to wait for both before I reached out), I'm not entirely sure how you update the project but just wanted to let you know!

anatol commented 9 months ago

Thank you for handling the upstreaming process!

First upstream needs to make a new release with these patches. Then android-tools bumps to that release. At this point the patches will no longer needed in the android-tools repo and can be dropped.

Biswa96 commented 7 months ago

First upstream needs to make a new release with these patches.

Would it be possible to request a new tag in upstream aosp? platform tools version 34.0.5 was released in October 2023^1.

doronbehar commented 7 months ago

I too need this update please :pray:.