Closed z3ntu closed 5 months ago
Please wait until the pending pull request is being resolved.
I don't see how it could conflict with #132 though, is there some concern there?
@z3ntu could you please send a pull request for this patch? It will help to move changes forward.
@anatol #139
According to upstream[0] there are several cases of variables or struct members not being initialized, but since they're using
-ftrivial-auto-var-init=zero
to build the code, those will be zero-initialized by the compiler already.The CMake files should add this flag also to not hit bugs[1] due to uninitialized variables.
I assume we should be able to add these lines here https://github.com/nmeum/android-tools/blob/master/vendor/CMakeLists.txt#L18
Let me know if I should open a pull request with this or if you have other suggestions.
[0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/comments/233c6468_46a055c5
[1] https://gitlab.archlinux.org/archlinux/packaging/packages/android-tools/-/issues/4