search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Initial Snap packaging #141

Closed fredldotme closed 4 months ago

fredldotme commented 5 months ago

Includes everything required to run android-tools in the Snap package itself, targetted against core22.

This includes strict confinement to work without requiring further review from the Snapcraft forums and works on immutable systems like Ubuntu Core, Ubuntu Core Desktop & Ubuntu Touch.

The permissions to achieve full functionality are part of the description, which will be available in the Snapcraft.io listing page once released.

Takes the most recent git tag version as the Snap package's release version.

Attention: In order to quickly build-cycle through changes to this .yaml file it is encouraged to clean the tools part once patches have been applied in a previous build attempt, ie through snapcraft clean tools.

anatol commented 5 months ago

Is there any way to automate testing/validitation of this snap config? Something that can be integrated into the github workflow?

fredldotme commented 5 months ago

The usual workflow I'm familiar with is registering the Snap's name in https://snapcraft.io and connecting the repo, which then allows for rebuilds for every single push or merge to master.

These builds land (if successful) in the edge channel. A promotion can be manually triggered through the snapcraft.io website in the "Releases" tab.

Thaodan commented 5 months ago

Does it make sense to add these to the repository? E.g. RPM or Debian packaging isn't contained in the repository either.

fredldotme commented 5 months ago

If folks here are willing to take the lead on being an upstream for something then yes, it makes sense. My thinking was that the listing could show a checkmark as a vetted publisher, as is usually the case with trusted App Stores.

EDIT: Also having a reference package to point to would be nice. I would still maintain the package, but I'm more comfortable with downloading a package from someone with a checkmark rather than some "random stranger".

anatol commented 4 months ago

Why did you close it?

fredldotme commented 4 months ago

I was under the impression of no movement/lowered interest, and I am not a fan of leaving PRs open for a month. If that was a misunderstanding I am more than willing to reopen it.