Closed eli-schwartz closed 2 months ago
CI failure is the return of the terrible horrible no good very bad GitHub Actions Python...
thank you @eli-schwartz for your contribution!
I actually realized I should have deleted the patches/base/ as well, and pushed an amended commit approximately 90 seconds after you merged the PR. :D
I actually realized I should have deleted the patches/base/ as well, and pushed an amended commit approximately 90 seconds after you merged the PR. :D
np, please send another PR.
There are some leftovers that can be removed. I shall create a pull request with those change.
I actually cannot find any traces of it ever being used but it certainly isn't used now. It builds a bunch of code for a static library that is never consumed, which is both slow and also potentially erroring out (since the unused code contains strict-aliasing violations).
Fixes: #148