search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Remove libandroidfw: it was never used #149

Closed eli-schwartz closed 2 months ago

eli-schwartz commented 2 months ago

I actually cannot find any traces of it ever being used but it certainly isn't used now. It builds a bunch of code for a static library that is never consumed, which is both slow and also potentially erroring out (since the unused code contains strict-aliasing violations).

Fixes: #148

eli-schwartz commented 2 months ago

CI failure is the return of the terrible horrible no good very bad GitHub Actions Python...

anatol commented 2 months ago

thank you @eli-schwartz for your contribution!

eli-schwartz commented 2 months ago

I actually realized I should have deleted the patches/base/ as well, and pushed an amended commit approximately 90 seconds after you merged the PR. :D

anatol commented 2 months ago

I actually realized I should have deleted the patches/base/ as well, and pushed an amended commit approximately 90 seconds after you merged the PR. :D

np, please send another PR.

eli-schwartz commented 2 months ago

https://github.com/nmeum/android-tools/pull/150

Biswa96 commented 2 months ago

There are some leftovers that can be removed. I shall create a pull request with those change.