Closed ollieparanoid closed 3 years ago
Have you submitted this upstream to AOSP? Technically this is a functional difference from the original code, right? Because up until now the modifications made by the patches employed by this repository focus exclusively on fixing compilation errors.
Yep, it's a functional difference. I didn't realize that patches in this repo are only for compilation errors.
Have you submitted this upstream to AOSP?
They seriously require a google account with phone number to upstream patches :\ But I guess I'll take that route some time soon to get this in.
This seems to be the upstream patch for this problem https://android-review.googlesource.com/c/platform/system/core/+/1611279
This seems to be the upstream patch for this problem https://android-review.googlesource.com/c/platform/system/core/+/1611279
Thanks for pointing it out. That change got metered aosp repo. It is better to pull the upstream fix for the given problem.
fyi with latest android-tools (28d072ed39af12190f206564af359844fcd02430) this particular issue is solved but seems to have introduced a different problem which is "fastboot: error: boot partition is smaller than boot image", presumably when fastboot can't get the partition size then it assumes 0 or whatever?
@z3ntu: hm :\ so the upstream patch needs a follow up that replaces the newly introduced die("boot partition is smaller than boot image");
in copy_boot_avb_footer
with verbose("boot partition is smaller than boot image, assuming non-avb device"); return;
(like in my patch)
do you want to try this and contact upstream patch author / submit it as follow-up there?
Hey @z3ntu and @ollieparanoid, any update on this by any chance?
I think I only had the problem on the FP2 and I was able to fix the bootloader there to work properly with new fastboot so I'm not hitting this anymore.
Don't crash in copy_boot_avb_footer() if bootloaders do not properly expose the size of the boot partition.
This makes "fastboot flasher boot" usable again on lots of non-avb-devices, where it has been broken since I5a5e25fb54dc9d6a2930fda63434968808ffa1f0.
Fixes: https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2007