search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
170 stars 51 forks source link

vendor/core/NOTICE is gone in 31.0.2 #30

Open munix9 opened 3 years ago

munix9 commented 3 years ago

vendor/core/NOTICE is gone in 31.0.2 so this leads to an error in make install

See upstream https://android.googlesource.com/platform/system/core.git/+log/refs/tags/platform-tools-31.0.2/NOTICE https://android.googlesource.com/platform/system/core.git/+/2f51435809f29d2fa3e3dab82617813c121e9721

See github actions build https://github.com/munix9/android-tools/runs/2703531103?check_suite_focus=true#step:7:2184


Install the project...
/usr/bin/cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /usr/local/share/bash-completion/completions/adb
-- Installing: /usr/local/share/bash-completion/completions/fastboot
-- Installing: /usr/local/share/zsh/site-functions/_adb
-- Installing: /usr/local/share/zsh/site-functions/_fastboot
-- Installing: /usr/local/bin/adb
-- Installing: /usr/local/bin/fastboot
-- Installing: /usr/local/bin/mke2fs.android
-- Installing: /usr/local/bin/simg2img
-- Installing: /usr/local/bin/img2simg
-- Installing: /usr/local/bin/append2simg
-- Installing: /usr/local/share/android-tools/completions/adb
-- Installing: /usr/local/share/android-tools/completions/fastboot
CMake Error at vendor/cmake_install.cmake:174 (file):
  file INSTALL cannot find
  "/__w/android-tools/android-tools/vendor/core/NOTICE": No such file or
  directory.
Call Stack (most recent call first):
  cmake_install.cmake:48 (include)

make: *** [Makefile:118: install] Error 1
Error: Process completed with exit code 2.```
nmeum commented 3 years ago

Thanks for pointing this out, keep in mind though that 31.0.2 is not merged yet.

munix9 commented 3 years ago

Yes, I know, this is currently only for testing. Another question: Where do the used patches actually come from?

nmeum commented 3 years ago

Another question: Where do the used patches actually come from?

From contributors to this repository, initially a few have been copied from Arch.

nmeum commented 3 years ago

I think I will just remove the NOTICE for the upcoming release, see https://github.com/nmeum/android-tools/pull/20#issuecomment-853097683