search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
191 stars 57 forks source link

Add Dynamic Partition Tools #51

Closed moetayuko closed 2 years ago

moetayuko commented 2 years ago

This PR adds tools to handle dynamic partitions (super.img), tested working on archlinux.

moetayuko commented 2 years ago

BTW the library dependencies are not well-organized. Arguably each static/dynamic library should declare its dependencies via target_link_libraries and export its headers via target_include_directories, rather than handcrafting all deps when building the executable. Any plan to refactor in the future?

nmeum commented 2 years ago

BTW the library dependencies are not well-organized. Arguably each static/dynamic library should declare its dependencies via target_link_libraries and export its headers via target_include_directories, rather than handcrafting all deps when building the executable. Any plan to refactor in the future?

Yes, that's currently a bit messy indeed. I personally haven't gotten around to refactoring this part of the build system yet and I am not sure if I will have the time do to so in the foreseeable future but I would welcome contributions addressing this issue.

moetayuko commented 2 years ago

@nmeum Now it passes the CI build in my fork, please double-check.

moetayuko commented 2 years ago

bump, is this mergeable now?