search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Add mkdtboimg tool #68

Closed JamiKettunen closed 1 year ago

JamiKettunen commented 2 years ago

This is a tool for packing multiple DTB/DTBO files into a single image which is used by bootloader on various Android devices since circa 2017.

libufdt is now tracking tag platform-tools-33.0.3 as #65 has been merged.

JamiKettunen commented 2 years ago

@nmeum Any comments? I'd like some feedback to get this merged eventually.

nmeum commented 1 year ago

@nmeum Any comments? I'd like some feedback to get this merged eventually.

I haven't looked into it yet, as I want to upgrade to 33.0.1 first. If you have the time, maybe consider helping out with the remaining compiler issue in #65 so we can move forward with this. My time to work an android-tools is unfortunately a bit limited right now.

If this tool is needed by pmOS, I am a also more than willing to give push access to more pmOS people.

JamiKettunen commented 1 year ago

This is indeed already an extra package on postmarketOS: https://gitlab.com/postmarketOS/pmaports/-/tree/master/main/android-mkdtboimg

Unfortunately I don't think I have enough C++ understanding to fix a template error like what's seen in the upgrade PR :/

JamiKettunen commented 1 year ago

@nmeum Rebased, the python3 shebang fix also was included in 33.0.3 so no need to potentially patch it here :)

JamiKettunen commented 1 year ago

@nmeum Ping

anatol commented 1 year ago

@nmeum I do not have objections to including this tool.

Are you OK to move forward with this PR?