search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Fix mkbootimg since 33.0.3 upgrade #78

Closed JamiKettunen closed 1 year ago

JamiKettunen commented 1 year ago

It now requires an import of a gki/generate_gki_certificate.py, so install the scripts in /usr/share/android-tools/mkbootimg and symlink back to /usr/bin/mkbootimg to avoid having to patch anything.

Suggestions for a better way to create the symlink are welcome, I'm not entirely happy with it, but it does work :)

Fixes #76.

JamiKettunen commented 1 year ago

Now that I thought about it ${CMAKE_INSTALL_FULL_DATADIR}/android-tools (otherwise known as /usr/share/android-tools) would be a better place to put the scripts in than the rather arbitrary /usr/lib/android-tools.

I guess now my question is do I put the files in a /usr/share/android-tools/mkbootimg subdir? I've done that for now as well, let me know if anything should be changed.

JamiKettunen commented 1 year ago

Would it be possible to also get #68 merged before creating a new 33.0.3p1 tag with this imho rather important fix included?