search

nmeum / android-tools

Unoffical CMake-based build system for android command line utilities
Apache License 2.0
177 stars 51 forks source link

Delete 0003-socket.h-include-sys-select.h-for-fd_set-used-in-soc.patch #80

Closed Biswa96 closed 1 year ago

Biswa96 commented 1 year ago

Upstream https://android-review.googlesource.com/c/platform/system/core/+/1797015

Biswa96 commented 1 year ago

The build failure in opensuse is not related to the current changes.

Biswa96 commented 1 year ago

May I ask what the rules are about upstreaming patches (if possible)? I am using this project for Windows platform. Would there be any issue if I upstream patches from here? Or only the author of the patch has permission to do so?

anatol commented 1 year ago

May I ask what the rules are about upstreaming patches (if possible)?

Upstreaming patches are very very welcome. This way, our project will reduce the maintenance burden.

Or only the author of the patch has permission to do so?

You either need approval from the author OR you need to rewrite the patches. Fortunately, most of the patches are trivial and easy to redo.