search

nmfisher / flutter_filament

3D rendering layer for Flutter/Filament
Other
44 stars 7 forks source link

MacOS universal libs & repo cleanup #11

Closed daverin closed 6 months ago

daverin commented 7 months ago

Built filament macOS with -l flag for universal binaries:

./build.sh -l release

Also did some cleanup in the repo: 1) Since macos/src and macos/include are copied from ios they shouldn't be included in git, but copied at build time. 2) gitattributes made simpler for easier management 3) makefile shortcuts for common commands 4) fvm added to example project

nmfisher commented 7 months ago

Thanks @daverin - I'm guessing you built the main branch in https://github.com/nmfisher/filament/ (which is at v1.44.0), is that right? I was actually building against the flutter-filament-ios-android-macos branch (which is at v1.43.1), but I hadn't specified that in the README just yet.

daverin commented 6 months ago

Ah that makes sense. Cool I'll rebuild from that branch 🙌🏾

daverin commented 6 months ago

Updated my branch to use built libraries from flutter-filament-ios-android-macos.

Tested on macOS and iOS.

Please check it out @nmfisher

nmfisher commented 6 months ago

@daverin looks like your fork has been deleted (did that happen automatically when I transitioned this repository from private to public?). If you're able to fork again and push, I can merge this in now.

daverin commented 6 months ago

@nmfisher I force pushed on this branch to make it cleaner after all the unnecessary source changes I made.

You might have to re-pull.

To confirm, the branch is daverin:feature/mac-os-universal commit e190686efe56d47ef4e877ce3881a84c60dc73f7

daverin commented 6 months ago

I'll do a rebase to make it easy for you to merge!

daverin commented 6 months ago

Replaced by https://github.com/nmfisher/flutter_filament/pull/15