nmfs-fish-tools / SSMSE

Management Strategy Evaluation (MSE) using Stock Synthesis (SS3)
https://nmfs-fish-tools.github.io/SSMSE
MIT License
18 stars 11 forks source link

Forecast File Inputs not copying? #214

Open Mkrig24 opened 5 months ago

Mkrig24 commented 5 months ago

I am running an MSE using sablefish stock assessment files, which have catch inputs specified at the bottom of the forecast file that cap catch at the ACLs set by council in the first two years of the model. When the model runs outside of SSMSE these inputs correctly cap the catch, but I noticed that inside of run_SSMSE, when the forecast file gets copied to _EM_init these input values aren't copied over, and the catch ends up being significantly higher.

image becomes image

Is there a way to make sure these inputs are copied over? Or another work around to get catch specified correctly in these first two years?

k-doering-NOAA commented 5 months ago

@Mkrig24 thank you for the question! Here is the code that is removing the forecast catch inputs: https://github.com/nmfs-fish-tools/SSMSE/blob/1f12b27f65403062d914a79d6e239e5ccb3e9dc0/R/manipulate_EM.R#L395-L402

This was done because there isn't one obvious way to apply forecast catch inputs as the simulation projects forward in time without the user providing additional information.

Right now, I believe the only way to get catch specified in the forecast file would be to develop a custom management procedure - @nathanvaughan-NOAA, does that sound correct?

nathanvaughan-NOAA commented 5 months ago

That is all correct @k-doering-NOAA we have similar issues in the Southeast with a lag between the assessment data end year and management implementation year but don't have a good solution at the moment for defaulting this setup in SSMSE. A custom management procedure is likely the only solution if you want to explicitly include this in an MSE. @Mkrig24 if you look at the merge_catch_bias branch we are currently working on developing some custom EM's in the ratioBiasEM.R file that may help you with figuring out how to setup your own custom EM.