search

nmfs-fish-tools / fishdictionary

A dictionary scheme for fisheries
https://connect.fisheries.noaa.gov/fishdictionary
GNU Affero General Public License v3.0
5 stars 1 forks source link

Use json schema to validate terms in the dictionary #37

Closed Bai-Li-NOAA closed 1 year ago

Bai-Li-NOAA commented 1 year ago

We have a json schema file here. It would be great if we can use the schema file to validate all existing terms in the dictionary (.R files) or new terms in the future.

k-doering-NOAA commented 1 year ago

I think the idea is slightly different, but in case it is helpful, I recently setup a job to validate JSON files using a JSON schema for the FIT webpages: https://github.com/noaa-fisheries-integrated-toolbox/toolbox_web_templating/blob/main/.github/workflows/validate_json_config.yml (not sure if you have access, but I can add you if needed!)

Bai-Li-NOAA commented 1 year ago

Thanks for sharing the yml file. I have access to the file. It is cool that you can set up a GHA workflow to validate JSON files. We probably will modify the yml file and give it a try after converting all the Rd files to JSON files.

On Thu, Oct 6, 2022 at 9:22 AM Kathryn Doering @.***> wrote:

I think the idea is slightly different, but in case it is helpful, I recently setup a job to validate JSON files using a JSON schema for the FIT webpages: https://github.com/noaa-fisheries-integrated-toolbox/toolbox_web_templating/blob/main/.github/workflows/validate_json_config.yml (not sure if you have access, but I can add you if needed!)

— Reply to this email directly, view it on GitHub https://github.com/nmfs-fish-tools/fishdictionary/issues/37#issuecomment-1270038825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJI36USQOVMN2DOAEGU4E3WB3HCLANCNFSM6AAAAAAQ6SWLXI . You are receiving this because you authored the thread.Message ID: @.***>