nmfs-fish-tools / fishdictionary

A dictionary scheme for fisheries
https://connect.fisheries.noaa.gov/fishdictionary
GNU Affero General Public License v3.0
5 stars 1 forks source link

Get rid of warnings and notes from rcmdcheck #49

Open Bai-Li-NOAA opened 11 months ago

Bai-Li-NOAA commented 11 months ago

This pull request resolves issue #48 by implementing the following changes to eliminate warnings and notes that appear during the execution of devtools::check():

kellijohnson-NOAA commented 11 months ago

@Bai-Li-NOAA thank you so much for fixing these things. If you don't mind, I would like to force push a change to this branch that will better align with the other changes that we have made in synonym where we use :: rather than importFrom. I like the former better than the latter because it gives other readers a better chance at knowing where the function comes from because you technically do not have to import a function from another package more than once, which can lead to the importFrom not being in the .Rd for every relevant function, which can be confusing.

Bai-Li-NOAA commented 11 months ago

@kellijohnson-NOAA , great. please feel free to force make any changes to this branch!