search

nmfs-fish-tools / ghactions4r

Reusable github actions workflows for R packages
https://nmfs-fish-tools.github.io/ghactions4r/
12 stars 1 forks source link

add support for multiple triggers? #135

Open iantaylor-NOAA opened 4 months ago

iantaylor-NOAA commented 4 months ago

It might be helpful to run doc-and-style, for instance on both pushes to the main branch and also pull requests to resolve issues before merging. Currently the build_trigger argument only allows a single value from the list, but couldn't it be modified to use match.arg(..., several.ok = TRUE) to allow multiple options? Other changes in the code would presumably be required as well. https://github.com/nmfs-fish-tools/ghactions4r/blob/2695d1af07acf1ab9f2f38742485ed3ace47932b/R/use_r_workflows.R#L121-L127

k-doering-NOAA commented 3 months ago

Good point @iantaylor-NOAA ! This does seem useful.