nmfs-fish-tools / ghactions4r

Reusable github actions workflows for R packages
https://nmfs-fish-tools.github.io/ghactions4r/
12 stars 1 forks source link

Doc and style changes #138

Closed k-doering-NOAA closed 2 months ago

k-doering-NOAA commented 2 months ago

Partially addresses #136 and #137 by:

Additionally, this corrects outdated documentation suggesting that the rm_dollar_sign function was in the {r4ss} pkg; it is in {ghactions4r}.

@iantaylor-NOAA , I thought you would be best to review this, but perhaps @Bai-Li-NOAA can review if you are not able to!

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (2695d1a) to head (b4df853).

Files Patch % Lines
R/use_r_workflows.R 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #138 +/- ## ========================================== - Coverage 95.47% 95.02% -0.46% ========================================== Files 3 3 Lines 199 201 +2 ========================================== + Hits 190 191 +1 - Misses 9 10 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

k-doering-NOAA commented 2 months ago

Thanks for reviewing @iantaylor-NOAA !

@Bai-Li-NOAA will be maintaining ghactions4r over the next few months :)