search

nmfs-fish-tools / ghactions4r

Reusable github actions workflows for R packages
https://nmfs-fish-tools.github.io/ghactions4r/
12 stars 1 forks source link

[Bug]: peter-evans/create-pull-request@v3 should be updated to v4 #56

Closed kellijohnson-NOAA closed 1 year ago

kellijohnson-NOAA commented 1 year ago

Describe the bug

peter-evans/create-pull-request@v3 should be updated to v4 according to the README on peter-evans/create-pull-request.

This affects the following lines of code in this repository: https://github.com/nmfs-fish-tools/ghactions4r/blob/ba096637ce4b5cdb90332d0e46b67a55217e687d/.github/workflows/update-roxygen-docs.yml#L43 https://github.com/nmfs-fish-tools/ghactions4r/blob/ba096637ce4b5cdb90332d0e46b67a55217e687d/.github/workflows/style-r-code.yml#L44 https://github.com/nmfs-fish-tools/ghactions4r/blob/ba096637ce4b5cdb90332d0e46b67a55217e687d/.github/workflows/doc-and-style-r.yml#L128

To Reproduce

When the GitHub actions are ran the following error message is generated in GitHub actions

Node.js 12 actions are deprecated.
For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: peter-evans/create-pull-request@v3

Expected behavior

No warnings from the GitHub action. Once the actions are updated to use v4 the warning regarding the node goes away. I have tested this in a different repository.

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which browser are you seeing the problem on?

No response

Which version of ghactions4r are you seeing the problem on?

No response

Additional Context

I will submit a pull request for this.

k-doering-NOAA commented 1 year ago

Thanks for catching this @kellijohnson-NOAA and offering to submit a PR! That would be great.