nmfs-opensci / quarto_titlepages

A Quarto extension for making title and cover pages for PDF output.
https://nmfs-opensci.github.io/quarto_titlepages/
Creative Commons Zero v1.0 Universal
115 stars 20 forks source link

Incorrect LaTeX syntax results in wrong line skip #34

Open samcarter opened 1 year ago

samcarter commented 1 year ago

System settings:

Description

A simple test file like

---
title: "Some Very Long Title Which Spans Multiple Lines "  
format:  
  titlepage-pdf:  
    titlepage-theme:   
      title-fontstyle: Huge
---  

test

will result in the following latex syntax for the title:

{{\Huge{\nohyphens{Some Very Long Title Which Spans Multiple
Lines}}}\par
}%

There are a couple of problems with this syntax. The most important one is that the paragraph is ended at the wrong position. If you insert \par only after you switched back from the custom font size, then the text will be set with a wrong baselineskip (the one from the normal font around it and not with your title font). Try the following two lines to see the difference:

{{\Huge{\nohyphens{Some Very Long Title Which Spans Multiple
Lines}}}\par
}%

{{\Huge{\nohyphens{Some Very Long Title Which Spans Multiple
Lines}}\par}
}%
Screenshot 2023-02-08 at 10 45 56

Another potential problem: Depending on what comes after the title, you might get an additional space from the unprotected line ending after \par}

Not a problem as such, just unnecessary:

eeholmes commented 1 year ago

Thanks for bringing this up. I am not able to replicate your image. Mine looks ok with the title broken where expected.

image

Re font size commands, I don't know what font styles the user will use and \whatevertheyputin{...} seemed to be a fairly robust solution. However in general the font specs commands, like \Huge, have been a bit flakey. Using title-fontsize which takes a different approach to setting font size has been more robust.

My system settings and what I compiled with:

I'll try updating my quarto to the latest version and see if that changes things.

samcarter commented 1 year ago

Thanks for bringing this up. I am not able to replicate your image. Mine looks ok with the title broken where expected.

The break point is fine, but as also evident in your image, the spacing between the lines is wrong. The y and the L nearly touch each other. That's because the \par is at the wrong position in the code.

226378922-695e8d44-a3f9-42e9-8d5d-e76301054670
eeholmes commented 1 year ago

EEH: to do for this issue

{{\Huge{\nohyphens{Some Very Long Title Which Spans Multiple
Lines}}}\par
}%

{{\Huge{\nohyphens{Some Very Long Title Which Spans Multiple
Lines}}\par}
}%