nmfs-ost / ss3-doc

Source code for the Stock Synthesis manual and other documentation
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
4 stars 3 forks source link

improve description of hermaphroditism #258

Closed iantaylor-NOAA closed 3 weeks ago

iantaylor-NOAA commented 4 weeks ago

Here's a draft pull request inspired by this recent conversation https://groups.google.com/g/ss3-forum/c/S-Krkkn9qao.

If an equation is necessary, we can likely do something similar to the description of the parameter trends which also use cumulative normal functions: https://github.com/nmfs-ost/ss3-doc/blob/main/tv_parameter_description.tex#L81.

See issue #259

github-actions[bot] commented 4 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

github-actions[bot] commented 4 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

e-perl-NOAA commented 3 weeks ago

@iantaylor-NOAA please see my comment in the issue and my additional commits. I'm going to convert this from a draft to ready for review.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

iantaylor-NOAA commented 3 weeks ago

@e-perl-NOAA, thanks for your work on this. Can you take one more look at this and if it looks good then squash and merge? Additional changes include

This resolves issue #259.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.

marcnadon commented 3 weeks ago

Thank you all, this is much clearer now. Appreciate the super quick response to this issue!

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.

e-perl-NOAA commented 3 weeks ago

@iantaylor-NOAA Thanks so much for your work on this!

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.html Please review your changes in the linked artifacts.

github-actions[bot] commented 3 weeks ago

Here are the artifacts from your PR: SS330_User_Manual.pdf textidote_report Please review your changes in the linked artifacts.