search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

Refining a warning message #324

Open k-doering-NOAA opened 2 years ago

k-doering-NOAA commented 2 years ago

For this warning: https://github.com/nmfs-stock-synthesis/stock-synthesis/blob/7c4cbd501ae20cd5dca0fc8c18febd97324fde9f/SS_readdata_330.tpl#L529

I was wondering if a suggestion about what should be done should be added (e.g., add a really small value like 0.001 amount of catch) to help user figure out what to do if they run into it? I expect this warning will come up because there are many reasons there may be 0 catch in the last year (esp. in simulation studies).

k-doering-NOAA commented 2 years ago

Also, wasn't sure if adding a small amount of catch is the right thing to do in all cases.

Rick-Methot-NOAA commented 2 years ago

The model needs catch (especially needs F) in the endyr in order to calculate the relative F among fleets. Without that, it has no basis for adjusting those F's for the forecast. So perhaps what we need to do is back up and come up with alternative way to get to relF among fleets.

iantaylor-NOAA commented 2 years ago

Seems like in some cases folks won't care about benchmarks or forecast so can just ignore the issue. In other cases they will want to change the year associated with the benchmark to make sure it isn't connected to the final year. In other cases they'll want to change the catch.

k-doering-NOAA commented 2 years ago

Ah, ok. So many potential solutions depending on what people want to do. Maybe if this isn't in the manual (and it may be), adding suggestion there makes more sense than adding to the warning message?

k-doering-NOAA commented 2 years ago

Closing because opened an issue in the doc repo instead.

e-perl-NOAA commented 1 month ago

Reopen to clarify controls related to relative F among fleets and provide documentation as seen in ss3-doc issue #117.