search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
37 stars 16 forks source link

[Refactor]: remove unused variables related to ALK? #415

Closed iantaylor-NOAA closed 1 year ago

iantaylor-NOAA commented 1 year ago

Refactor request

While discussing workflows with @k-doering-NOAA yesterday, I looked at the artifact generated by the call-build-ss3-warnings workflow https://github.com/nmfs-stock-synthesis/stock-synthesis/actions/workflows/call-build-ss3-warnings.yml and discovered that the number of warnings has significantly reduced, presumably thanks to changes between ADMB version.

The remaining warnings are shown in the warnings_ss_ref.txt file available here: https://github.com/nmfs-stock-synthesis/workflows/blob/main/reference_files/warnings_ss_ref.txt (which is copied from the artifact from the most recent github action run on the main branch a few days ago).

The warnings all seem to be related to unused variable ‘ALK_finder’, as well as unused variable ‘ALK_finder’, unused parameter ‘ALK_range_lo’, and unused parameter ‘ALK_range_hi’. I presume that these are unused after deprecating the ALK tolerance code in Pull Request #342. If there is a good reason to keep there around, there's no problem ignoring the warnings, but if we can make the warnings go away, it will be that much easier to notice new warnings that appear in the future.

Expected behavior

Have even fewer warnings.

Rick-Methot-NOAA commented 1 year ago

Neal, can you just comment out the creation of these variables? Or is it more complicated?

nschindler-noaa commented 1 year ago

Yes. right away.

nschindler-noaa commented 1 year ago

This is in main?

nschindler-noaa commented 1 year ago

created branch remove-unused-ALK-variables commented them out.