search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

implement changes and warnings for recr surveys #474

Closed Rick-Methot-NOAA closed 1 year ago

Rick-Methot-NOAA commented 1 year ago

see info with the issue

What tests have been done?

temporary edits to simple example were used to test display of the new warnings recr_svy_test.zip

Where are the relevant files?

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

[x] No, there was no input change.

Additional information (optional).

Rick-Methot-NOAA commented 1 year ago

The example you tried had a forecast phase = 6, which is good and so doesn't need change. I will add a condition such that that warning will only appear if forecast phase is <=0.

e-perl-NOAA commented 1 year ago

I ran the test model that you attached and got the note in the warning.sso. I also ran the growth_timevary model which has a survey where the unit is 32 and the last year of that survey is 2009 but the last year of main recdev is 2009. I get the following note: Note 2 Suggestion: Recruitment survey: 4 has data in: 2009, which is after last main recdev: 2008. Suggest extend recdev_end, or change fore_devs phase: 6 so it seems things are working as they should.

Rick-Methot-NOAA commented 1 year ago

Thanks. Please edit the manual per the text I put in the issue #466

e-perl-NOAA commented 1 year ago

I re-ran the growth_timevary model and no longer get: Note 2 Suggestion: Recruitment survey: 4 has data in: 2009, which is after last main recdev: 2008. Suggest extend recdev_end, or change fore_devs phase: 6 so that all seems to be good.