search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

Update add vuln bio #513

Closed Rick-Methot-NOAA closed 11 months ago

Rick-Methot-NOAA commented 11 months ago

Concisely describe what has been changed/addressed in the pull request.

something went wrong in the merging of the add_vuln_bio issue. Fixing it here.

499

e-perl-NOAA commented 11 months ago

@iantaylor-NOAA We will need to figure out what is going on with r4ss here.

Rick-Methot-NOAA commented 11 months ago

candidate r4ss issues are columns in time_series report or catch report. Also, the added table of selmax that occurs after the age_selectivity report.

iantaylor-NOAA commented 11 months ago

One more request, related to the already-merged previous pull request #499. Could you replace the blank line and add an underscore to change as follows?

From:


maximum ASEL2

to:

#
maximum_ASEL2

This makes it find the new output in r4ss and makes it consistent with other output tables (where blank lines are followed by sections calls "report:NN" and sub-sections within a table are separated by #).

Rick-Methot-NOAA commented 11 months ago

sorry about that Ian. Thanks for reminding me of the agreed protocol.

iantaylor-NOAA commented 11 months ago

Thank you. I made one more minor change in 325dbd4. Hopefully that's OK too.

Rick-Methot-NOAA commented 11 months ago

Thanks Ian