Closed Rick-Methot-NOAA closed 10 months ago
e-perl-NOAA
commented
10 months ago @Rick-Methot-NOAA, can you walk me through where these changes are showing up in the report file a bit more? At first glance, the logic seems fine but I'm having a hard time finding where it will show up. @iantaylor-NOAA Maybe you could help me out with this since Rick is at PICES this week?
Rick-Methot-NOAA
commented
10 months ago The output is only in forecast-report.sso and is not used by any R read functions that I know of. Basically it is just for my investigation of user problems when they occur.
On Mon, Oct 23, 2023 at 7:13 AM Elizabeth Gugliotti < @.***> wrote:
@Rick-Methot-NOAA https://github.com/Rick-Methot-NOAA, can you walk me through where these changes are showing up in the report file a bit more? At first glance, the logic seems fine but I'm having a hard time finding where it will show up. @iantaylor-NOAA https://github.com/iantaylor-NOAA Maybe you could help me out with this since Rick is at PICES this week?
— Reply to this email directly, view it on GitHub https://github.com/nmfs-stock-synthesis/stock-synthesis/pull/521#issuecomment-1775299082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPV4IFMRHHFZH7K2RJ6JJTYAZ3QJAVCNFSM6AAAAAA6JUFR2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGI4TSMBYGI . You are receiving this because you were mentioned.Message ID: @.***>
format of the MSY search output was corrupted when there is >1 season. Fix by using colsum to output the sum of catch across seasons for each fleet.
There is no issue.
What tests have been done?
examined revised output and verified that it was correct to use colsum, not rowsum
Where are the relevant files?
[x] No test files are required for this pull request.