nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

[Refactor]: Rename repos within nmfs-stock-synthesis organization to add "ss3" in front #524

Closed iantaylor-NOAA closed 8 months ago

iantaylor-NOAA commented 10 months ago

Issue description

This plan has been discussed in meetings and resulted in four open Pull Requests thanks to @e-gugliotti-NOAA. I've just reviewed those changes and they all look good, but I think it would be helpful to have an issue outside of those PRs in which to discuss the details of the changes before merging them.

Summary of issue history, discussion, and major aspects of code development

https://github.com/nmfs-stock-synthesis/stock-synthesis/pull/523/ (for this repo) https://github.com/nmfs-stock-synthesis/doc/pull/200/ https://github.com/nmfs-stock-synthesis/user-examples/pull/26/ https://github.com/nmfs-stock-synthesis/test-models/pull/47/

Items to do

Here are a few tasks that seems worth planning for. Please edit this list as needed.

repository needs repo names updated updated in branch branch merged
ICES-course-2023 yes yes
ssi no no
.github-private yes yes
.github yes yes
workflows to delete to delete
get_labels ? ?
helper ? ?
tpl-format ? ?
ss-flowcharts ? ?
nmfs-stock-synthesis.github.io no no

Does documentation already exist in the SS3 User Manual?

No, the documentation that should be added to the SS3 User Manual pertaining to this issue is provided below.

Documentation to add to the SS3 User Manual OR link to existing documentation

It may be worth noting somewhere in the user manual that the repo name changed.

Are r4ss changes needed?

Yes, this issue requires changes to r4ss (if selecting this, please add iantaylor-NOAA as an Assignee in the panel to the right).

Are SSI changes needed?

No, this issue doesn't require changes to SSI

Rick-Methot-NOAA commented 10 months ago

An additional consideration is links from previous release notes to the old repo names. This is an immediate issue because a new release, with associated links, is nearly ready. I think we should delay the release until after the repo naming is settled.

e-perl-NOAA commented 10 months ago

I think that this would be easiest to do right before/in tandem with the next release (this would make it easier in terms of the release for the documentation and not having to do it twice). It will likely take a couple of days where links aren't all correct but it shouldn't take long to get the most important ones sorted out quickly and the rest in the following days. I propose that we do these things on Monday and Tuesday (Oct. 30th and 31st) when @Rick-Methot-NOAA is done with PICES, and it looks like our calendars are more free to dedicate most of the day to implementation and clean-up.

e-perl-NOAA commented 10 months ago

@iantaylor-NOAA Of the 10 repos:

iantaylor-NOAA commented 10 months ago

Update based on discussion between @Rick-Methot-NOAA, @e-gugliotti-NOAA, @kellijohnson-NOAA, and @iantaylor-NOAA: renaming the repos will occur at a separate time not associated with the release. This will allow the "nmfs-stock-synthesis" organization to be brought into the "nmfs-ost" organization at the same time as renaming the individual repos within the org. Proposed timeline would be in a few weeks to a month. The timing is not yet right for moving the org and this avoids two separate renaming steps requiring users to track the new location twice.

An additional consideration to be decided on before renaming repos is the possibility of reorganizing the repo hierarchy such as merging the documentation and source code repos which are currently separate.

Rick-Methot-NOAA commented 10 months ago

A related issue is the discussions for which we provide access to the public. The old team discussions capability was deprecated, so now all discussions are in one place. But some items in this location are conversations among team members. Can we segregate public discussions from team discussions? Perhaps we need one of our repos to be private so our internal team discussions could be linked to that repo? Perhaps workflow? Here is a tool for repo management, but it seems rather experimental and not Windows oriented: https://gerrit.googlesource.com/git-repo/ This article advocates for large Orgs and using Teams to manage granular access to repos in that Org

e-perl-NOAA commented 10 months ago

For the team discussions:

Do these team discussions need to be removed from public access?

Do we plan on using team discussions in the future? Most discussions seem to happen in PRs and Issues that are still available for the public to view so it doesn't seem like we would use them going forward.

Rick-Methot-NOAA commented 10 months ago

Good questions. To date, I think the content of the Team discussions has been equivalent to the content in Issues and PR, so I think they can remain. Followup questions in our G_Spaces.

Rick-Methot-NOAA commented 10 months ago

Should the ICES course repo be repurposed to a general repo for training material rather than replicate the material each time we teach a new course? The content can be "tagged" for each course.

e-perl-NOAA commented 10 months ago

I think that this is a great idea!

e-perl-NOAA commented 10 months ago

@Rick-Methot-NOAA I have changed the repo name for the ices course to be ss3-trainings. I also updated the README.md to reflect his change. If we build this repo out more, we can always create a github.io site with pages for each training.