nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

update readme with file name changes for doc #528

Closed e-perl-NOAA closed 10 months ago

e-perl-NOAA commented 10 months ago

Concisely describe what has been changed/addressed in the pull request.

Fix links to user manual tutorials given file name changes to ss3 instead of ss.

What tests have been done?

Where are the relevant files?

What tests/review still need to be done?

None.

Is there an input change for users to Stock Synthesis?

Additional information (optional).

trevorhutton commented 10 months ago

Thank you for "responding" - however this problem still exists.

iantaylor-NOAA commented 10 months ago

Hi @trevorhutton, the old links don't work, but the landing page https://nmfs-stock-synthesis.github.io/doc/ has been updated to point to the new links which do work: https://nmfs-stock-synthesis.github.io/doc/Getting_Started_SS3.html https://nmfs-stock-synthesis.github.io/doc/ss3_model_tips.html

The source of the change was a cleanup throughout the SS3 repositories of using "SS3" consistently instead of "SS".

iantaylor-NOAA commented 10 months ago

Correction: it was the README that got updated, not the main github.io/doc page. It may require refreshing https://github.com/nmfs-stock-synthesis/stock-synthesis/ to get the updated links.

e-perl-NOAA commented 9 months ago

@trevorhutton Did refreshing the page update the links for you?

trevorhutton commented 9 months ago

Dear Elizabeth

No, I still get:

404 File not found The site configured at this address does not contain the requested file. If this is your site, make sure that the filename case matches the URL as well as any file permissions. For root URLs (like http://example.com/) you must provide an index.html file. Read the full documentationhttps://help.github.com/pages/ for more information about using GitHub Pages. Best

Trev.

From: Elizabeth Gugliotti @.> Sent: Wednesday, November 29, 2023 4:52 AM To: nmfs-stock-synthesis/stock-synthesis @.> Cc: Hutton, Trevor (Environment, St. Lucia) @.>; Mention @.> Subject: Re: [nmfs-stock-synthesis/stock-synthesis] update readme with file name changes for doc (PR #528)

@trevorhuttonhttps://github.com/trevorhutton Did refreshing the page update the links for you?

— Reply to this email directly, view it on GitHubhttps://github.com/nmfs-stock-synthesis/stock-synthesis/pull/528#issuecomment-1830482487, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD6GHGXVRKT33B7RFSZ5SNDYGYXFZAVCNFSM6AAAAAA7K6GEQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGQ4DENBYG4. You are receiving this because you were mentioned.Message ID: @.**@.>>

e-perl-NOAA commented 9 months ago

@trevorhutton Can you provide me the link to the page that you see these broken links on?

trevorhutton commented 9 months ago

Yes

Home - Stock Synthesis - Virtual Lab (noaa.gov)https://vlab.noaa.gov/web/stock-synthesis

Go to 1) and PUSH link to Getting Started.

Best

Trev.

From: Elizabeth Gugliotti @.> Sent: Wednesday, November 29, 2023 4:58 AM To: nmfs-stock-synthesis/stock-synthesis @.> Cc: Hutton, Trevor (Environment, St. Lucia) @.>; Mention @.> Subject: Re: [nmfs-stock-synthesis/stock-synthesis] update readme with file name changes for doc (PR #528)

Can you provide me the link to the page you see these links on?

— Reply to this email directly, view it on GitHubhttps://github.com/nmfs-stock-synthesis/stock-synthesis/pull/528#issuecomment-1830491366, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD6GHGXDNHGK5LODBH2LHKTYGYX4ZAVCNFSM6AAAAAA7K6GEQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGQ4TCMZWGY. You are receiving this because you were mentioned.Message ID: @.***>

e-perl-NOAA commented 9 months ago

Ohhhhhh okay, I think we were just confused on which site you were seeing the bug on. I have now updated those links on vlab so they should work now.

trevorhutton commented 9 months ago

Dear Elizabeth

Works perfectly.

In Cairns (Aus) on a business trip), as normally based in Brisbane. Timing is great as now using SS now.

Say hi to Andre for me if you see him,

Best

Trev.

From: Elizabeth Gugliotti @.> Sent: Wednesday, November 29, 2023 5:26 AM To: nmfs-stock-synthesis/stock-synthesis @.> Cc: Hutton, Trevor (Environment, St. Lucia) @.>; Mention @.> Subject: Re: [nmfs-stock-synthesis/stock-synthesis] update readme with file name changes for doc (PR #528)

Ohhhhhh okay, I think we were just confused on which site you were seeing the bug on. I have now updated those links on vlab so they should work now.

— Reply to this email directly, view it on GitHubhttps://github.com/nmfs-stock-synthesis/stock-synthesis/pull/528#issuecomment-1830532010, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD6GHGQLEGTGUSBFSOI4MFLYGY3C3AVCNFSM6AAAAAA7K6GEQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQGUZTEMBRGA. You are receiving this because you were mentioned.Message ID: @.**@.>>