search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

fix size comp method output #539 #540

Closed iantaylor-NOAA closed 8 months ago

iantaylor-NOAA commented 9 months ago

Concisely describe what has been changed/addressed in the pull request.

Fixes bad value reported for size comp method (in Ageerr column of CompReport.sso)

What tests have been done?

Where are the relevant files?

Running with simple_small_sizecomp model (attached to issue #539) now produces CompReport.sso file with size comp method values that match 3.30.19 output.

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

No.

iantaylor-NOAA commented 9 months ago

build-ss3 test had this error message: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

@e-gugliotti-NOAA, do you have any idea what might cause this?

I will try to re-run the test in case that helps.

iantaylor-NOAA commented 9 months ago

@e-gugliotti-NOAA, ignore my question about failed build-ss3 github actions. They worked after re-running (took 2 tries in the case of hte Mac-OS one).

e-perl-NOAA commented 8 months ago

@iantaylor-NOAA, yes, I saw that on Friday just as I was about to log off and did a quick search of GitHub to see if there was any information on it. All that came up was someone else's GHA run on the same day that returned the same error. I assume that it had something to do with the GHA runner. Glad that re-running it worked!