search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

Admb docker images #550

Closed e-perl-NOAA closed 6 months ago

e-perl-NOAA commented 7 months ago

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

Where are the relevant files?

What tests/review still need to be done?

Is there an input change for users to Stock Synthesis?

Additional information (optional).

e-perl-NOAA commented 7 months ago

@Rick-Methot-NOAA and @johnoel can you look at the build-ss3.yml and see why those errors exist? It looks like it might be errors in the ss3 tpl files. Just created a draft PR because it's easier to see the testing in a PR than on a branch.

Rick-Methot-NOAA commented 7 months ago

I see the code successfully pulling from johnoel/admb-linux and then failing to build it for a C++ reason that should not be occurring. Later when it tries for windows, it cannot connect to: johnoel/admb-windows. Wish I knew enough to help more.

e-perl-NOAA commented 7 months ago

@Rick-Methot-NOAA I couldn't tell if it was a C++/ss3 issue with linux, but yes, with windows the admb docker still isn't working.

Rick-Methot-NOAA commented 7 months ago

Do we need to reach out to additional people who have docker experience? perhaps in the R user group or the FIMS team?

e-perl-NOAA commented 7 months ago

I'm hoping we can get this sorted out with @johnoel because we definitely want to make sure that the admb docker image is working with our workflows. The linux and mac ones were working but now they aren't again. The windows one has never worked for me.

johnoel commented 7 months ago

I will check on this now...

johnoel commented 7 months ago

Running the ADMB Docker container within a GitHub Action container is most likely the issue. Using the ADMB Docker on a local host works just fine.

e-perl-NOAA commented 7 months ago

the linux and mac images did work until rebasing my branch and adding the changes from your recent commits. The windows image never worked so that might be a github action runner issue, though I haven't gotten the windows docker image to run locally either.

johnoel commented 7 months ago

Okay, I'll try again

e-perl-NOAA commented 7 months ago

I just created a new branch from main and added your changes in there in case the issue was the result of a merge conflict. The branch is admb-docker-attempt2 if you look in the actions tab to see how those run. I decided to just comment out the windows image and focus on the linux and mac images at least for now since I know at one point those worked. I've also just focused on the ss3-build workflow just to start.

johnoel commented 7 months ago

See Pull Request #552

e-perl-NOAA commented 6 months ago

Closing because testing on a different branch and will make a new PR to use admb docker image in other workflows when ready.