search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

[Bug]: Fit_Age and compreport.sso are showing different values for lbin_lo #556

Closed Rick-Methot-NOAA closed 6 months ago

Rick-Methot-NOAA commented 6 months ago

Describe the bug

A model with CAAL was using data_length bins to specify lbin_lo: 2 #_Lbin_method: 1=poplenbins; 2=datalenbins; 3=lengths The population length bins are 1 cm and the data length bins are 2 cm.

Compreport.sso is showing the lbin_lo and lbin_hi in units of cm, as expected. but FIT_AGE_COMPS is showing the population bin number.

To Reproduce

see above

Expected behavior

same value in both places

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

No response

Additional Context

fix entails changing FIT_AGECOMP to use len_bins(Lbin_lo(f, i)), rather than Lbin_lo(f, i)

With this change, the output is correct:

FIT_AGE_COMPS report:28
Fleet Fleet_Name Area Yr Seas Subseas Month Time Sexes Part Ageerr Lbin_lo Lbin_hi SuprPer Use Nsamp_in Nsamp_adj Nsamp_DM effN Like  All_obs_mean All_exp_mean All_delta All_exp_5% All_exp_95% All_DurWat
1 SC_Recreational 1 1989 1 2 7 1989.5 0 2 1 28 28  _  _ 1 1 1  0.0750871 2.66383  1.5 0.570004 0.929996 0 1.28476 2.99965
1 SC_Recreational 1 1989 1 2 7 1989.5 0 2 1 36 36  _  _ 1 1 1  28.4343 0.0442524  1.5 1.48385 0.0161507 1.02116 1.96188 2.25052
1 SC_Recreational 1 1989 1 2 7 1989.5 0 2 1 50 50  _  _ 1 1 1  1.70614 0.50925  1.5 1.93139 -0.431385 1.0832 2.95118 0.913786