nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

[Fix]: Fix workflows to use docker image & fix build-ss3-warnings.yml #563

Closed e-perl-NOAA closed 2 months ago

e-perl-NOAA commented 6 months ago

Issue description

Need to fix the workflow files after Johnoel's branch is merged. @Rick-Methot-NOAA I added this to the change-log so that we know to include in the next release notes that there is now the capability to compile ss3 using docker.

Summary of issue history, discussion, and major aspects of code development

See PR #552 & PR #561

Items to do

Does documentation already exist in the SS3 User Manual?

No, the documentation that should be added to the SS3 User Manual pertaining to this issue is provided below.

Documentation to add to the SS3 User Manual OR link to existing documentation

NA (all GitHub actions focused).

Are r4ss changes needed?

No, this issue doesn't require changes to r4ss

Are SSI changes needed?

No, this issue doesn't require changes to SSI

Rick-Methot-NOAA commented 6 months ago

Excellent to see this success. A final step could be a vignette showing how to work with docker.

johnoel commented 6 months ago

Okay, will do. Please hold off on the merge...

johnoel commented 6 months ago

the build-ss3.yml tests building ss3 before installing ADMB. I will update the manuals to describe the workflow with docker.

e-perl-NOAA commented 2 months ago

Closed with PR #552 and #568.