[workflows]: Test ADMB-13.2pre docker images

e-perl-NOAA commented 5 months ago

Issue description

From @johnoel: Not official releases, but the docker images for ADMB-13.2pre can be used for testing. https://hub.docker.com/r/johnoel/admb-13.2/tags

Summary of issue history, discussion, and major aspects of code development

NA

Items to do

[x] Create branch to call ADMB-13.2pre docker images in workflows
[x] Test branch

Does documentation already exist in the SS3 User Manual?

No, the documentation that should be added to the SS3 User Manual pertaining to this issue is provided below.

Documentation to add to the SS3 User Manual OR link to existing documentation

NA

Are r4ss changes needed?

No, this issue doesn't require changes to r4ss

Are SSI changes needed?

No, this issue doesn't require changes to SSI

e-perl-NOAA commented 5 months ago

@johnoel Just tested the build workflow (branch with changes - admb-13.2-pre-test), it seems like the windows image is building but mac and linux are not. What I'm getting from the failed workflow is:

Status: Downloaded newer image for johnoel/admb-13.2:linux
WARNING: The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
exec /usr/local/bin/admb: exec format error

johnoel commented 5 months ago

Okay, I will redo the linux docker images.

johnoel commented 5 months ago

Updated docker images, please try again and let me know.

e-perl-NOAA commented 5 months ago

@johnoel the docker images are now working on GitHub actions. Haven't had a chance to test admb locally with or without the docker image yet (need to get IT to enter admin privileges again). Will do that early next week.

johnoel commented 5 months ago

Okay, can you test using admb-13.2:linux-arm64 on the MacOS builds?

e-perl-NOAA commented 5 months ago

There is the following warning on the MacOS build: WARNING: The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested though it looks it might have still built...the action is still spinning and might be stuck somewhere. I'll give it a little while longer to sort itself out and then I'm going to stop it so that it doesn't use up all of our action minutes.

e-perl-NOAA commented 5 months ago

@johnoel I had to stop the action to build the ss3 MacOS image because it was spinning and spinning but not making any progress.

johnoel commented 5 months ago

Thank you for testing, I will just delete the admb-13.2:linux-arm64 image.

e-perl-NOAA commented 5 months ago

@johnoel have you tried using the admb docker image with macos-14 (macos-latest in github actions is macos-12)? I was trying to do some debugging on an ss3 issue that a mac user ran into with macos-14 but when I tried to build ss3 on that OS I get an error from the action (link to action output error). It looks like this is a docker issue and I searched around on the internet for various solutions but haven't found any that have worked.

johnoel commented 5 months ago

Shoots, i just deleted the admb-13.2:linux-arm64 image. I will rebuild and upload tomorrow.

e-perl-NOAA commented 5 months ago

Yeah that one didn't work on macos-latest. I don't know when you deleted it but I tried it this morning and it also didn't work (thought it might have not worked because you already deleted it)

johnoel commented 5 months ago

for macos with arm64, it wiould probably need that image. i will upload again soon

johnoel commented 5 months ago

Okay, reuploaded johnoel/admb-13.2:linux-arm64. Try that with the macOS-14 build.

Please let me know

e-perl-NOAA commented 5 months ago

@johnoel It's a no-go on the arm-64 docker image for the macOS-14 build (see github actions output). It seems like maybe there is an issue with colima?

johnoel commented 5 months ago

Try adding -f to colima command

brew update
colima delete
colima start -f --arch aarch64 --ssh-config=false

johnoel commented 5 months ago

See update to command above... idea from

e-perl-NOAA commented 5 months ago

Still no. And if I don't do brew install colima then I get the following error: /Users/runner/work/_temp/0010f3de-014d-4009-b030-3f6aa7c1a997.sh: line 2: colima: command not found. But even with installing colima it doesn't work. Please see failed github action: https://github.com/nmfs-ost/ss3-source-code/actions/runs/8265699034/job/22611959643#step:8:130

e-perl-NOAA commented 5 months ago

@msupernaw

johnoel commented 5 months ago

try again…. hello brother matt

msupernaw commented 5 months ago

yo bruddah, howzit?

On Wed, Mar 13, 2024 at 12:44 PM johnoel @.***> wrote:

try again…. hello brother matt

— Reply to this email directly, view it on GitHub https://github.com/nmfs-ost/ss3-source-code/issues/574#issuecomment-1994941163, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFUSEDAGT6A6QH2M4ORM3TYYB645AVCNFSM6AAAAABD27ESFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUHE2DCMJWGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Matthew Supernaw Scientific Software Developer National Oceanic and Atmospheric Administration Office Of Science and Technology NOAA Fisheries | U.S. Department of Commerce Phone 248 - 396 - 7797

e-perl-NOAA commented 5 months ago

Still no: https://github.com/nmfs-ost/ss3-source-code/actions/runs/8268826624/job/22622642638#step:8:35

msupernaw commented 5 months ago

Ok, this one failed to connect to docker. Any idea why?

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

On Wed, Mar 13, 2024 at 1:35 PM Elizabeth Perl @.***> wrote:

Still no: https://github.com/nmfs-ost/ss3-source-code/actions/runs/8268826624/job/22622642638#step:8:35

— Reply to this email directly, view it on GitHub https://github.com/nmfs-ost/ss3-source-code/issues/574#issuecomment-1995113683, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFUSEGCDKRVS2DX45Z5NYTYYCE4NAVCNFSM6AAAAABD27ESFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVGEYTGNRYGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Matthew Supernaw Scientific Software Developer National Oceanic and Atmospheric Administration Office Of Science and Technology NOAA Fisheries | U.S. Department of Commerce Phone 248 - 396 - 7797

e-perl-NOAA commented 5 months ago

I took out the colima commands to see if getting rid of those would change anything since it was still not working with them in there.

msupernaw commented 5 months ago

I think we need to have the action upload the artifact. Not sure how or where to add it yet though. See below for FIMS.

name: Upload check results if: failure() uses: @.*** with: name: ${{ runner.os }}-r${{ matrix.config.r }}-results path: check

On Wed, Mar 13, 2024 at 1:53 PM Elizabeth Perl @.***> wrote:

I took out the colima commands to see if getting rid of those would change anything since it was still not working with them in there.

— Reply to this email directly, view it on GitHub https://github.com/nmfs-ost/ss3-source-code/issues/574#issuecomment-1995175143, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFUSEDCFTGNYDIP2IJ2TY3YYCHAPAVCNFSM6AAAAABD27ESFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVGE3TKMJUGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Matthew Supernaw Scientific Software Developer National Oceanic and Atmospheric Administration Office Of Science and Technology NOAA Fisheries | U.S. Department of Commerce Phone 248 - 396 - 7797

msupernaw commented 5 months ago

This https://github.com/actions/upload-artifact may help.

On Wed, Mar 13, 2024 at 2:42 PM Matthew Supernaw - NOAA Federal < @.***> wrote:

I think we need to have the action upload the artifact. Not sure how or where to add it yet though. See below for FIMS.

name: Upload check results if: failure() uses: @.*** with: name: ${{ runner.os }}-r${{ matrix.config.r }}-results path: check

On Wed, Mar 13, 2024 at 1:53 PM Elizabeth Perl @.***> wrote:

I took out the colima commands to see if getting rid of those would change anything since it was still not working with them in there.

— Reply to this email directly, view it on GitHub https://github.com/nmfs-ost/ss3-source-code/issues/574#issuecomment-1995175143, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFUSEDCFTGNYDIP2IJ2TY3YYCHAPAVCNFSM6AAAAABD27ESFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVGE3TKMJUGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Matthew Supernaw Scientific Software Developer National Oceanic and Atmospheric Administration Office Of Science and Technology NOAA Fisheries | U.S. Department of Commerce Phone 248 - 396 - 7797

-- Matthew Supernaw Scientific Software Developer National Oceanic and Atmospheric Administration Office Of Science and Technology NOAA Fisheries | U.S. Department of Commerce Phone 248 - 396 - 7797

johnoel commented 5 months ago

it works on my machine which is Sonoma, but try adding the brew update (see update above).

ohh, you need colima to run docker.

e-perl-NOAA commented 5 months ago

Okay after so many trials and configurations of colima and qemu and everything else I finally got past that to a different error:

Status: Downloaded newer image for johnoel/admb-13.2:linux-arm64
docker.io/johnoel/admb-13.2:linux-arm64
!!version_info += "#V3.30.22.beta: not an official version of SS;_safe;_compile_date:_";
-- Building ss3 with docker in 'SS330' --
WARNING: The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64/v1) and no specific platform was requested
exec /usr/local/bin/admb: exec format error

johnoel commented 5 months ago

Working... see https://github.com/admb-project/admb/actions/runs/8284008651/workflow

e-perl-NOAA commented 5 months ago

Okay so I should be using the linux image, not the arm-64 one.

johnoel commented 5 months ago

yes, for github actions …

e-perl-NOAA commented 5 months ago

Okay, great! We have success finally!

e-perl-NOAA commented 3 months ago

See PR #587 for update to ADMB-13.2

nmfs-ost / ss3-source-code