search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

Revise warning when extending time-blocks into forecast years #579

Closed IJStewart closed 8 months ago

IJStewart commented 8 months ago

Describe the bug

The 3.30.22.1 manual recommends use of "9999" as the end year of the terminal time block in order to ensure it will extend to cover the entire forecast period (page 217). However, when this approach is used, a warning is generated "...9999 reset to YrMax: XXXX". As this is a recommended approach, I don't think it should generate a warning.

To Reproduce

Set the end of the last time block to "9999".

Expected behavior

Extension of the block to the end of the forecast period without a warning.

Screenshots

No response

Which OS are you seeing the problem on?

Windows

Which version of SS3 are you seeing the problem on?

3.30.22.1

Additional Context

No response

Rick-Methot-NOAA commented 8 months ago

Thanks Ian. I will revise the code such that if the user enters 9999, SS3 will not generate a warning.