nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
36 stars 16 forks source link

Unify F approach #580

Closed Rick-Methot-NOAA closed 5 months ago

Rick-Methot-NOAA commented 5 months ago

continues development for issue #570 and especially #581 See description and example in #581 Substantial refactoring of the internal machinery for managing F as parameter vs F as hybrid extends the F-detail approach previously available only for F_method 2 to F_method 4

only new input is for F_method 4 if using the F_detail feature.

e-perl-NOAA commented 5 months ago

Okay so the spinydogfish model echoinput file is stopping after:

GP Seas Area Use? female_recr_dist
1 1 1 1 0.5
 made the age_age' key 
Finished evaluating biology calculations once

Begin estimating

Warning file looks like the following:

Note 1 Information: Max data length bin: 132  < max pop len bins: 136; so will accumulate larger pop len bins
3 iter 1
 hrate for 1970: 
Rick-Methot-NOAA commented 5 months ago

that stop in dogfish might only be because I had not yet removed a specific output statement while debugging. It is gone now.

e-perl-NOAA commented 5 months ago

Yes, all seems to be working!

Rick-Methot-NOAA commented 5 months ago

Thanks Ian. Nothing magic about the 2.9 value. The role of max F is mostly to keep model from exploring F levels that nearly extirpate older fish. In the attached example, it is constraining during early hybrid phases to keep F below 2.9, which creates a catch penalty, which moves model back to higher biomass and lower F values. For long-lived stocks a maxF of 0.4 might seem reasonable, but even 0.40 will not extirpate.