Concisely describe what has been changed/addressed in the pull request.
The M2 chip macs that use arm64 (including macos-14) seem to behave a bit differently with the ss3 executables than the macs that use x86_64 architecture (macos-12 and before). Building the executable on a macos-14 runner fixed the issue that a user (Juan-Carlos) was having. I have now included building on a macos-14 machine in our GitHub actions. @iantaylor-NOAA noted that the macos-14 built executable does not work on older macs so building macos-12 is also necessary.
In theory, the macos-latest image is supposed to be macos-14 right now BUT a recent run testing updates I'm making to the r4ss get_ss3_exe() function to get the m2 exe showed that it had an x86_64 architecture OS (see R.version output) which is NOT what macos-14 had, so I'm not sure what's up there. When it does sort itself out, i'll switch where it says macos-14 to macos-latest.
The macos-12 runner will eventually be discontinued. The macos-13 runner does not create an exe that will work when built with the workflow that uses the docker image (despite 2 days of trying) but it will create an exe that will work when built using the build-admb-and-ss3 workflow.
I added a mac version that works for the arm64 architecture onto the v.3.30.21.1 release.
Also officially updated to admb 13.2 version for github actions.
What tests have been done?
Where are the relevant files?
[x] No test files are required for this pull request. -->
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
e-perl-NOAA
commented
4 months ago
Concisely describe what has been changed/addressed in the pull request.
The M2 chip macs that use arm64 (including macos-14) seem to behave a bit differently with the ss3 executables than the macs that use x86_64 architecture (macos-12 and before). Building the executable on a macos-14 runner fixed the issue that a user (Juan-Carlos) was having. I have now included building on a macos-14 machine in our GitHub actions. @iantaylor-NOAA noted that the macos-14 built executable does not work on older macs so building macos-12 is also necessary.
In theory, the macos-latest image is supposed to be macos-14 right now BUT a recent run testing updates I'm making to the r4ss get_ss3_exe() function to get the m2 exe showed that it had an x86_64 architecture OS (see R.version output) which is NOT what macos-14 had, so I'm not sure what's up there. When it does sort itself out, i'll switch where it says macos-14 to macos-latest.
The macos-12 runner will eventually be discontinued. The macos-13 runner does not create an exe that will work when built with the workflow that uses the docker image (despite 2 days of trying) but it will create an exe that will work when built using the build-admb-and-ss3 workflow.
I added a mac version that works for the arm64 architecture onto the v.3.30.21.1 release.
Also officially updated to admb 13.2 version for github actions.
What tests have been done?
Where are the relevant files?
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
Additional information (optional).