nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

[Bug]: "inf" value in bootstrap of mean size-at-age data for ages with sample size 0 #598

Open iantaylor-NOAA opened 6 months ago

iantaylor-NOAA commented 6 months ago

Describe the bug

@e-perl-NOAA reported "inf" values in the bootstraps of the mean size-at-age data for the BigSkate_2019 test model. I was able to replicate the issue in the attached files.

There is a single vector of observations where the last three bins (for males age 13-15) have 0 sample size. The bootstrap observations are reported as inf 0.0001 inf in data_boot_001.ss and as 0.0001 inf inf in data_boot_002.ss in the attached files: boot.zip.

It looks like the code here may be randomly generating a mix of inf and -inf and then replacing the -inf with 0.0001. https://github.com/nmfs-ost/ss3-source-code/blob/main/SS_write_ssnew.tpl#L1271-L1275

I think the following steps should be taken:

Note that these data are excluded from the likelihood with a lambda = 0 setting, but I think that doesn't matter for any of this.

To Reproduce

Run the attached input files (which is just the BigSkate_2019 in ss3-test-models with the starter file changed to produce bootstrap files).

Expected behavior

A model without inf output that can be used as an SS3 input file.

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of SS3 are you seeing the problem on?

No response

Additional Context

No response