nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

make column headings more consistent in data files #608

Closed iantaylor-NOAA closed 3 months ago

iantaylor-NOAA commented 4 months ago

Initially posting as a draft pull request to foster discussion before marking ready for review.

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

None so far. The changes should only be to comments, not numerical values, so I don't think additional testing of SS3 itself is needed.

What tests/review still need to be done?

The read/write of data files by r4ss should be tested against these changes along with the status-quo output.

Is there an input change for users to Stock Synthesis?

[x] No, there was no input change.

iantaylor-NOAA commented 3 months ago

@e-perl-NOAA and I discussed the changes to SS3 and r4ss just now and made a few more tweaks, but we think this is now ready for review from @Rick-Methot-NOAA. We will also merge the parallel issue cleaning up r4ss column headers: https://github.com/r4ss/r4ss/pull/945.